[json rpc] deprecate indexes #18236
[json rpc] deprecate indexes #18236
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@phoenix-o is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
phoenix-o
force-pushed
the
cf_optional_depricate_indexes
branch
from
2e7f82c to
031f7ae
Compare
| @@ -233,6 +232,7 @@ pub struct IndexStore { | |||
| caches: IndexStoreCaches, | |||
| metrics: Arc<IndexStoreMetrics>, | |||
| max_type_length: u64, | |||
| remove_deprecated_tables: bool, | |||
There was a problem hiding this comment.
Do we have a way to unconditionally remove loaded_child_object_versions and conditionally remove the other two? That way everyone can benefit from that one being nuked while people can opt into the other two being removed?
There was a problem hiding this comment.
no, we don't at the moment. We can create a config with explicit list of column families to be removed. Or nuke loaded_child_object_versions unconditionally.
Ofc subject for discussion, but I kind of like it this way. Puts some minor pressure on FN operator to start migration process from JSON RPC
There was a problem hiding this comment.
Ok i'm fine with leaving it as-is (single config to remove all deprecated cfs) so long as we can unconditionally nuke loaded_child_object_versions for everyone regardless of this flag since there's no reason to keep it.
phoenix-o
force-pushed
the
cf_optional_depricate_indexes
branch
from
031f7ae to
6f79442
Compare
PR marks as deprecated following indexes: * transactions_by_input_object_id * transactions_by_mutated_object_id * loaded_child_object_versions
PR marks as deprecated following indexes: