-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create sui-setup.sh startup script for Cargo install through genesis #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
startup script for Cargo install through genesis
github-actions
bot
added
the
Type: Documentation
Improvements or additions to documentation
label
May 5, 2022
Clay-Mysten
requested review from
666lcz,
awelc,
lxfind,
patrickkuo and
sblackshear
May 5, 2022 07:15
666lcz
reviewed
May 5, 2022
Replace cargo installation with confirmation and link to doc for install
huitseeker
approved these changes
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I will need to delete the sui directory. |
Add directory removal
This seems to now do what we want:
And:
Going to push this. Thanks to Francois and Chris for their reviews. |
Make path to script explicit
Make doc comments better still
Display recommendation for manual install of VSCode extension in output
Attempting to add standard license header
longbowlu
pushed a commit
that referenced
this pull request
May 12, 2022
…1819) * Create sui-setup.sh startup script for Cargo install through genesis * Update sui-setup.sh Replace cargo installation with confirmation and link to doc for install * Update sui-setup.sh Add directory removal * Update sui-setup.sh Make path to script explicit * Update sui-setup.sh Make doc comments better still * Update sui-setup.sh Display recommendation for manual install of VSCode extension in output * Update sui-setup.sh Attempting to add standard license header
punwai
pushed a commit
that referenced
this pull request
Jul 27, 2022
…1819) * Create sui-setup.sh startup script for Cargo install through genesis * Update sui-setup.sh Replace cargo installation with confirmation and link to doc for install * Update sui-setup.sh Add directory removal * Update sui-setup.sh Make path to script explicit * Update sui-setup.sh Make doc comments better still * Update sui-setup.sh Display recommendation for manual install of VSCode extension in output * Update sui-setup.sh Attempting to add standard license header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.