Ensure gateway gas metering is consistent with authority #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfind
force-pushed
the
gateway-consistent-gas-meter
branch
from
66939d8 to
f3947b2
Compare
oxade
reviewed
May 4, 2022
|
@lxfind so this is not really adding new functionality but rather unifying existing ones for consistency right? |
Correct! |
oxade
approved these changes
May 4, 2022
lxfind
force-pushed
the
gateway-consistent-gas-meter
branch
from
f3d8ded to
e134722
Compare
Merged
longbowlu
pushed a commit
that referenced
this pull request
May 12, 2022
* Ensure gateway gas metering is consistent with authority * Fix type
punwai
pushed a commit
that referenced
this pull request
Jul 27, 2022
* Ensure gateway gas metering is consistent with authority * Fix type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1742.
The existing gas metering code on the gateway isn't consistent with authority. This leads to the case where gateway passes gas check, but failed on authority, leaving the objects locked on the gateway.
This PR moves all the transaction input checking logic into one single function in transaction_input_checker, and call it from all different places. This ensures consistency.