-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wallet] - rename transfer to transfer-coin #1762
Conversation
sui/src/bin/wallet.rs
Outdated
@@ -217,6 +217,7 @@ async fn handle_command( | |||
.collect::<Vec<_>>(); | |||
cache.insert(CacheKey::new("object", "--id"), objects.clone()); | |||
cache.insert(CacheKey::flag("--gas"), objects.clone()); | |||
cache.insert(CacheKey::flag("--coin-object-id"), objects.clone()); | |||
cache.insert(CacheKey::flag("--object-id"), objects); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we delete 221?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider closing / editing the error in #1747 while you're here.
* rename transfer to transfer-coin * address PR comment * improve transfer non coin error message * improve transfer non coin error message
* rename transfer to transfer-coin * address PR comment * improve transfer non coin error message * improve transfer non coin error message
the command now looks like this
The changes :
transfer
->transfer-coin
,--object-id
->--coin-object-id