Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet] - rename transfer to transfer-coin #1762

Merged
merged 4 commits into from
May 4, 2022

Conversation

patrickkuo
Copy link
Contributor

the command now looks like this

sui>-$ transfer-coin --to 3E809385696FAE27E41DB735AD0179892FCFE996 --coin-object-id 4604C9B1FBE3C38C21665DC8D84EBE1DE180C743 --gas 67584724B900A5EDDCBE04B276B6E9AE5A978BC8 --gas-budget 1000

The changes : transfer -> transfer-coin, --object-id -> --coin-object-id

@@ -217,6 +217,7 @@ async fn handle_command(
.collect::<Vec<_>>();
cache.insert(CacheKey::new("object", "--id"), objects.clone());
cache.insert(CacheKey::flag("--gas"), objects.clone());
cache.insert(CacheKey::flag("--coin-object-id"), objects.clone());
cache.insert(CacheKey::flag("--object-id"), objects);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we delete 221?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! good catch

Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider closing / editing the error in #1747 while you're here.

@patrickkuo patrickkuo merged commit 580f8ff into main May 4, 2022
@patrickkuo patrickkuo deleted the pat/rename_transfer_in_wallet branch May 4, 2022 19:44
longbowlu pushed a commit that referenced this pull request May 12, 2022
* rename transfer to transfer-coin

* address PR comment

* improve transfer non coin error message

* improve transfer non coin error message
punwai pushed a commit that referenced this pull request Jul 27, 2022
* rename transfer to transfer-coin

* address PR comment

* improve transfer non coin error message

* improve transfer non coin error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants