Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update links #17584

Merged
merged 3 commits into from
May 9, 2024
Merged

fix: update links #17584

merged 3 commits into from
May 9, 2024

Conversation

joyqvq
Copy link
Contributor

@joyqvq joyqvq commented May 8, 2024

Description

Describe the changes or additions included in this PR.

Test plan

fix some links and make multisig page inter linked.

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@joyqvq joyqvq requested a review from ronny-mysten May 8, 2024 17:43
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 4:20pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 4:20pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 4:20pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 4:20pm

@github-actions github-actions bot added the Type: Documentation Improvements or additions to documentation label May 8, 2024
- [Multisig](../../../concepts/cryptography/transaction-auth/multisig.mdx): Definition of multisig transactions on the Sui network and how to use it with CLI.
- [Multisig Typescript SDK](https://sdk.mystenlabs.com/typescript/cryptography/multisig): How to create multisig address and sign transactions using the Sui SDK.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how to link the sdk page's original page, feel free to fix @ronny-mysten

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is you've never not figured something out correctly. This case included ;)

Copy link
Contributor

@ronny-mysten ronny-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

docs/content/guides/developer/cryptography/multisig.mdx Outdated Show resolved Hide resolved
- [Multisig](../../../concepts/cryptography/transaction-auth/multisig.mdx): Definition of multisig transactions on the Sui network and how to use it with CLI.
- [Multisig Typescript SDK](https://sdk.mystenlabs.com/typescript/cryptography/multisig): How to create multisig address and sign transactions using the Sui SDK.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is you've never not figured something out correctly. This case included ;)

docs/content/guides/developer/cryptography/multisig.mdx Outdated Show resolved Hide resolved
@joyqvq joyqvq merged commit ec53ebc into main May 9, 2024
50 checks passed
@joyqvq joyqvq deleted the joy/update-doc-0504 branch May 9, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants