[move] Make usage of move serialization version explicit #17502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
tzakian
force-pushed
the
tzakian/explicit-move-version-ser
branch
from
4df57e6 to
05501a0
Compare
tzakian
force-pushed
the
tzakian/explicit-move-version-ser
branch
from
05501a0 to
ff0b728
Compare
tzakian
force-pushed
the
tzakian/explicit-move-version-ser
branch
from
ff0b728 to
a572593
Compare
tnowacki
approved these changes
May 6, 2024
Comment on lines
+46
to
+48
| let version = if config.bytecode_version > VERSION_6 { | ||
| module.version | ||
| } else { |
There was a problem hiding this comment.
This is unreachable currently, yeah?
| @@ -66,6 +69,7 @@ impl Default for VerifierConfig { | |||
| max_idenfitier_len: Some(DEFAULT_MAX_IDENTIFIER_LENGTH), | |||
| allow_receiving_object_id: true, | |||
| reject_mutable_random_on_entry_functions: true, | |||
| bytecode_version: VERSION_MAX, | |||
There was a problem hiding this comment.
How does this work when we cut a version?
There was a problem hiding this comment.
Normally when cutting an execution version, however when adding a new bytecode_version we will need to manually fix the bytecode_version in previous versions to the particular VERSION_MAX at the time they were cut. Overall I don't view this as too big of an issue though since when adding a new bytecode version a bunch of stuff needs to change all over the place anyways.
benr-ml
pushed a commit
that referenced
this pull request
May 8, 2024
## Description Require explicit binary version when serializing Move modules. ## Test plan Make sure existing tests pass. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Require explicit binary version when serializing Move modules.
Test plan
Make sure existing tests pass.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.