Vault reentrancy guard #17487
Merged
Vault reentrancy guard #17487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
longbowlu
approved these changes
May 3, 2024
Bridgerz
requested review from
a team,
amnn,
wlmyng,
stefan-mysten,
emmazzz,
suiwombat,
ronny-mysten,
mystenmark,
joyqvq,
kchalkias and
benr-ml
as code owners
Bridgerz
force-pushed
the
vault-reentrancy-gaurd
branch
from
4cdf93d to
ade5a19
Compare
Bridgerz
force-pushed
the
vault-reentrancy-gaurd
branch
from
1cabba8 to
cdd389f
Compare
Bridgerz
removed request for
a team,
amnn,
emmazzz,
kchalkias,
mystenmark,
joyqvq,
benr-ml and
ronny-mysten
longbowlu
reviewed
May 14, 2024
Comment on lines
+892
to
+902
| receive() external payable { | ||
| if (!attackInitiated) { | ||
| attackInitiated = true; | ||
| vault.transferETH(payable(address(this)), 100); | ||
| } | ||
| } | ||
|
|
||
| function attack() external payable { | ||
| attackInitiated = false; | ||
| vault.transferETH(payable(address(this)), 100); | ||
| } |
There was a problem hiding this comment.
why not
receive() external payable {
vault.transferETH(payable(address(this)), 100);
}
function attack() external payable {
vault.transferETH(payable(address(this)), 100);
}
There was a problem hiding this comment.
This would cause an Infinite loop / any call to the attack() function would run out of gas.
There was a problem hiding this comment.
wouldn't the reentrancy guard catch this in the 2nd loop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.