Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let validator reads key pair from network config and remove --address and --validator_idx #1736

Merged
merged 11 commits into from
May 4, 2022
Merged

Let validator reads key pair from network config and remove --address and --validator_idx #1736

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
97984fd
remove duplicated src/validator.rs
Apr 27, 2022
a54a4e1
Merge branch 'main' of https://github.com/MystenLabs/sui
Apr 29, 2022
1fa0c0a
Merge branch 'main' of github.com:MystenLabs/sui
May 2, 2022
0ce74dd
Merge branch 'main' of github.com:MystenLabs/sui
May 3, 2022
2318152
validator can read network config keypair to decide identity
May 3, 2022
3719dc7
fmt
May 3, 2022
06763d4
revert
May 3, 2022
b45285e
fix
May 3, 2022
77937a7
rebase
May 3, 2022
a07fa42
rebase
May 3, 2022
1caf0cc
update bench too
May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update bench too
  • Loading branch information
Lu Zhang authored and Lu Zhang committed May 3, 2022
commit 1caf0cce8ec7744395b408e7efc2d5ba55b751eb
2 changes: 0 additions & 2 deletions sui/src/benchmark/validator_preparer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,6 @@ impl ValidatorPreparer {
let child = Command::new(working_dir.clone().join(VALIDATOR_BINARY_NAME))
.arg("--genesis-config-path")
.arg(GENESIS_CONFIG_NAME)
.arg("--address")
.arg(&self.main_authority_address_hex)
.arg("--force-genesis")
.spawn()
.expect("failed to spawn a validator process");
Expand Down
10 changes: 1 addition & 9 deletions sui/src/bin/validator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ use sui::{
sui_commands::{genesis, make_server},
};
use sui_types::{
base_types::{decode_bytes_hex, encode_bytes_hex, SuiAddress},
base_types::{encode_bytes_hex, SuiAddress},
committee::Committee,
};
use tracing::{error, info};
Expand All @@ -34,14 +34,6 @@ struct ValidatorOpt {
#[clap(long)]
pub network_config_path: Option<PathBuf>,

/// Public key/address of the validator to start
#[clap(long, parse(try_from_str = decode_bytes_hex))]
address: Option<SuiAddress>,

/// Index in validator array of validator to start
#[clap(long)]
validator_idx: Option<usize>,

#[clap(long, help = "Specify host:port to listen on")]
listen_address: Option<String>,
}
Expand Down