[Consensus 2.0] register failure points for new consensus for simtests #17275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
akichidis
force-pushed
the
akichidis/consensus-failure-points
branch
from
ddb8f9c to
5f6e20e
Compare
mwtian
approved these changes
Apr 22, 2024
arun-koshy
approved these changes
Apr 22, 2024
| @@ -37,6 +37,8 @@ pub(crate) struct CommitObserver { | |||
| sender: UnboundedSender<CommittedSubDag>, | |||
| /// Persistent storage for blocks, commits and other consensus data. | |||
| store: Arc<dyn Store>, | |||
| /// The last committed sub dag | |||
| last_sub_dag: Option<CommittedSubDag>, | |||
There was a problem hiding this comment.
nit: instead of keeping the entire last committed subdag in memory what if we just kept the commit index + timestamp?
akichidis
force-pushed
the
akichidis/consensus-failure-points
branch
from
3223d18 to
4e769a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test plan
CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.