Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nexlint: introduce project linting #1705

Merged
merged 1 commit into from
May 2, 2022
Merged

nexlint: introduce project linting #1705

merged 1 commit into from
May 2, 2022

Conversation

bmwill
Copy link
Contributor

@bmwill bmwill commented May 2, 2022

This introduces custom project linting using the nexlint linting
framework. As a start this patch enables the following lints via cargo xlint:

  • detection of duplicate versions of direct dependencies
  • detection of irrelevant build dependencies
  • checking of license headers on various file types
  • ensuring the root Cargo.toml file is canonical

@bmwill bmwill requested a review from huitseeker May 2, 2022 05:37
@github-actions github-actions bot added the Type: Documentation Improvements or additions to documentation label May 2, 2022
huitseeker
huitseeker approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! can we get it for Narwhal & Mysten-infra?
you may need an ignore for difference

@bmwill
Copy link
Contributor Author

bmwill commented May 2, 2022

Yep! I spent some time a month or so ago getting nextlint ready for use but didn't get around to integrating it anywhere so this was my first attempt. Once this is in here I can easily do the same for the other repos.

@bmwill bmwill force-pushed the lint branch 2 times, most recently from 4181fff to 854aba8 Compare May 2, 2022 21:12
@bmwill
nexlint: introduce project linting
88bba9c 
This introduces custom project linting using the nexlint linting
framework. As a start this patch enables the following lints via `cargo
xlint`:

* detection of duplicate versions of direct dependencies
* detection of irrelevant build dependencies
* checking of license headers on various file types
* ensuring the root Cargo.toml file is canonical
@bmwill bmwill merged commit 30f7c0e into MystenLabs:main May 2, 2022
@bmwill bmwill deleted the lint branch May 2, 2022 21:57
@huitseeker huitseeker mentioned this pull request May 4, 2022
Merged
@huitseeker huitseeker mentioned this pull request Aug 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

Assignees
No one assigned
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmwill @huitseeker