Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Consensus] block stream subscription #17000

Merged
merged 2 commits into from
Apr 16, 2024
Merged

[Consensus] block stream subscription #17000

merged 2 commits into from
Apr 16, 2024

Conversation

mwtian
Copy link
Contributor

@mwtian mwtian commented Apr 1, 2024 •
edited
Loading

Description

Implements block subscription with stream block responses via tonic.
From experiments, this is shown to reduce latency jitters, especially between hosts in different continents.

Also, enable keepalive and message size limits in tonic.

Test Plan

CI
Private testnet

If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@vercel Vercel
Copy link

vercel bot commented Apr 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 4:52am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 4:52am
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 4:52am
mysten-ui ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 4:52am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 4:52am
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 4:52am

@vercel vercel bot temporarily deployed to Preview – mysten-ui April 1, 2024 22:28 Inactive
@mwtian mwtian force-pushed the consensus-subscriber branch from d8bdd84 to 42a1c0d Compare April 3, 2024 02:05
@mwtian mwtian changed the base branch from main to consensus-streaming April 3, 2024 02:06
@mwtian mwtian changed the base branch from consensus-streaming to main April 3, 2024 02:06
@vercel vercel bot temporarily deployed to Preview – mysten-ui April 3, 2024 02:06 Inactive
@mwtian mwtian force-pushed the consensus-subscriber branch from 42a1c0d to 0529394 Compare April 3, 2024 07:04
@mwtian mwtian changed the base branch from main to consensus-streaming April 3, 2024 07:04
@mwtian mwtian changed the title [Consensus] wip [Consensus] block stream subscription Apr 3, 2024
@vercel vercel bot temporarily deployed to Preview – mysten-ui April 3, 2024 07:05 Inactive
@mwtian mwtian marked this pull request as ready for review April 3, 2024 07:06
@mwtian mwtian requested review from akichidis and arun-koshy April 3, 2024 07:06
Base automatically changed from consensus-streaming to main April 3, 2024 17:37
@mwtian mwtian force-pushed the consensus-subscriber branch from 00b3625 to 1477ca3 Compare April 3, 2024 17:40
@vercel vercel bot temporarily deployed to Preview – mysten-ui April 3, 2024 17:41 Inactive
akichidis
akichidis reviewed Apr 3, 2024
View reviewed changes
@mwtian mwtian force-pushed the consensus-subscriber branch from 1477ca3 to 4aff583 Compare April 3, 2024 18:25
@vercel vercel bot temporarily deployed to Preview – mysten-ui April 3, 2024 18:26 Inactive
@mwtian mwtian requested a review from akichidis April 3, 2024 22:04
@mwtian mwtian force-pushed the consensus-subscriber branch from c9c987e to bbb81ef Compare April 3, 2024 22:06
@mwtian mwtian force-pushed the consensus-subscriber branch from bbb81ef to 680dc79 Compare April 3, 2024 22:09
@mwtian mwtian force-pushed the consensus-subscriber branch from 680dc79 to 9df01e3 Compare April 4, 2024 02:18
@mwtian mwtian force-pushed the consensus-subscriber branch from 880b008 to 1af2c9a Compare April 4, 2024 18:38
@mwtian mwtian force-pushed the consensus-subscriber branch from 1af2c9a to b2c258b Compare April 4, 2024 19:30
@mwtian mwtian force-pushed the consensus-subscriber branch from b32f160 to 8e33a27 Compare April 5, 2024 03:06
@mwtian mwtian force-pushed the consensus-subscriber branch from 8e33a27 to 7a13c0c Compare April 5, 2024 03:10
@mwtian mwtian force-pushed the consensus-subscriber branch from 7a13c0c to a63539a Compare April 5, 2024 21:39
@mwtian mwtian force-pushed the consensus-subscriber branch from a63539a to 9091360 Compare April 8, 2024 16:42
@mwtian mwtian force-pushed the consensus-subscriber branch from 9091360 to 886fb41 Compare April 9, 2024 18:59
@mwtian mwtian force-pushed the consensus-subscriber branch from 886fb41 to 6007eae Compare April 15, 2024 22:48
arun-koshy
arun-koshy approved these changes Apr 16, 2024
View reviewed changes
@mwtian mwtian force-pushed the consensus-subscriber branch from 6007eae to 90bc441 Compare April 16, 2024 04:22
@mwtian mwtian enabled auto-merge (squash) April 16, 2024 04:33
@mwtian mwtian force-pushed the consensus-subscriber branch from 90bc441 to 4b1336d Compare April 16, 2024 04:51
@mwtian mwtian merged commit 21ba643 into main Apr 16, 2024
44 checks passed
@mwtian mwtian deleted the consensus-subscriber branch April 16, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arun-koshy arun-koshy arun-koshy approved these changes

@akichidis akichidis Awaiting requested review from akichidis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwtian @akichidis @arun-koshy