unblock sui-tool download-db-snapshot #16979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tharbert
approved these changes
Apr 1, 2024
fix string type kebab-case google_project_id read google_project_id from env var
johnjmartin
force-pushed
the
jjm/tmp-unblock-suitool
branch
from
9f6c9a8 to
38fa2a6
Compare
johnjmartin
added a commit
that referenced
this pull request
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@tharbert noticed
sui-tool download-db-snapshotdoesn't currently work against our requester pays bucket. this fixes the problem.I'll cherry-pick this fix so it's included in the next release and doesn't break @tharbert's statefulset