[explorer] Updates Owned Objects to match RPC Model #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fungible objects should be aggregated (per previous discussion, default is aggregated view, and can expand by user action) |
Closed
@Andrew47 , According to the error in the screenshot, somehow you are calling the SDK function with an invalid id called Please Wait, therefore this error is expected. |
666lcz
reviewed
Apr 30, 2022
| } | ||
|
|
||
| function GetObjectsAPI({ id }: { id: string }) { | ||
| const [objects, setObjects] = useState([{ objectId: 'Please Wait' }]); |
There was a problem hiding this comment.
import type { ObjectRef } from 'sui.js';
Suggested change
| const [objects, setObjects] = useState([{ objectId: 'Please Wait' }]); | |
| const [objects, setObjects] = useState<ObjectRef[]>([]); |
This will help you get rid of the error
666lcz
force-pushed
the
andrew/ownedObjects
branch
from
ae467b0 to
52e6248
Compare
666lcz
approved these changes
May 2, 2022
|
Merging this to main now and will address the comments in separate PRs |
longbowlu
pushed a commit
that referenced
this pull request
May 12, 2022
Co-authored-by: Chris Li <666lcz@gmail.com>
punwai
pushed a commit
that referenced
this pull request
Jul 27, 2022
Co-authored-by: Chris Li <666lcz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Owned Objects Component such that the Address Results now display owned objects:
Note that comprehensive testing is inhibited by apparent errors in the API.