-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix narwhal dependency with net updates #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
approved these changes
Apr 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks a lot!
@lxfind suggested that I give a tech presentation about what we need from narwhal to support shared objects on Sui, so that we can keep it in mind while updating Narwhal.
That's an excellent idea!
longbowlu
pushed a commit
that referenced
this pull request
May 12, 2022
Fix narwhal & shared object support
punwai
pushed a commit
that referenced
this pull request
Jul 27, 2022
Fix narwhal & shared object support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority: High
Very important task, not blocking but potentially delaying milestones or limiting our offering
Status: Needs Review
PR is ready for review
sui-node
Type: Bug
Something isn't working
Type: Major Feature
Major new functionality or integration, which has a significant impact on the network
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems we had the following problem twice:
This PR fixes shared object support (on both the Narwhal and Sui side) while preserving all the new Narwhal features. It also provides tests that (should) systematically breaks when we make a mistake on Sui.
This PR however does not prevent us from making updates on Narwhal that will break shared object support on Sui. @lxfind suggested that I give a tech presentation about what we need from narwhal to support shared objects on Sui, so that we can keep it in mind while updating Narwhal.