[node] Follow latest & Safe client integration test #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdanezis
force-pushed
the
safe-client-integration-test
branch
from
cfb56c8 to
f017ee7
Compare
gdanezis
changed the title
9 tasks
gdanezis
force-pushed
the
safe-client-integration-test
branch
from
e774e08 to
64e7976
Compare
bmwill
reviewed
May 3, 2022
sui_core/src/safe_client.rs
Outdated
Comment on lines
192
to
207
| /* | ||
|
|
||
| TODO: check that the batch is within bounds given that the | ||
| bounds may now not be known by the requester. | ||
|
|
||
| if let Some(start) = &request.start { | ||
| fp_ensure!( | ||
| signed_batch.batch.initial_sequence_number >= *start | ||
| && signed_batch.batch.next_sequence_number | ||
| <= (*start + request.length + signed_batch.batch.size), | ||
| SuiError::ByzantineAuthoritySuspicion { | ||
| authority: self.address | ||
| } | ||
| ); | ||
| } | ||
| */ |
There was a problem hiding this comment.
Mind using line comments // for comment things out over block comments? Block comments make it difficult to know if code is live or dead when grepping
bmwill
approved these changes
May 3, 2022
added 3 commits
May 3, 2022 16:55
author George Danezis <george@danez.is> 1651169454 +0100 committer George Danezis <george@danez.is> 1651571250 +0100 Modify follower protocol to allow follow of latest Moved follower streaming to authority fmt Changed io to sui errors Added integration test for safe client Clean up [node] Basic gossip (#1676) * Simple gossip logic * Added gossip test + fix follower edge case at 0 * Add logging Co-authored-by: George Danezis <george@danez.is>
gdanezis
force-pushed
the
safe-client-integration-test
branch
from
64e7976 to
9f2b61e
Compare
lanvidr
approved these changes
May 3, 2022
| None | ||
| } else { | ||
| loop { | ||
| match local_state.subscriber.recv().await { |
There was a problem hiding this comment.
So now we listen to the subscriber instead of directly to the network, this is a good decoupling
longbowlu
pushed a commit
that referenced
this pull request
May 12, 2022
Modify follower protocol to allow follow of latest Moved follower streaming to authority Changed io to sui errors Added integration test for safe client [node] Basic gossip (#1676) * Simple gossip logic * Added gossip test + fix follower edge case at 0 * Add logging Co-authored-by: George Danezis <george@danez.is>
punwai
pushed a commit
that referenced
this pull request
Jul 27, 2022
Modify follower protocol to allow follow of latest Moved follower streaming to authority Changed io to sui errors Added integration test for safe client [node] Basic gossip (#1676) * Simple gossip logic * Added gossip test + fix follower edge case at 0 * Add logging Co-authored-by: George Danezis <george@danez.is>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We extend and test more thoroughly the follower API and safe client:
Option<TxSequence>as astartin the batch request, and it follows the latest transactions. It also takes alengthto denote how many items we expect.AuthorityStateand now returns a nice Stream ofBatchResponsesinstead of writing directly to the channel. The logic that connects that to a channel stays inAuthorityServer.