[Consensus] start service with unspecified IP #16658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mwtian
force-pushed
the
consensus-service
branch
from
4e67551 to
a23a439
Compare
arun-koshy
approved these changes
Mar 14, 2024
|
cc @sadhansood for the logging level change in |
|
Nice! |
tx-tomcat
pushed a commit
to tx-tomcat/sui-network
that referenced
this pull request
May 30, 2024
## Description Receive the network service IP from the host, instead of specifying it when starting the service. Among other reasons, this helps with binding to the same IP and port after stopping the service in sim tests. Also, - Allow the Mysticeti workflow to run from a branch or commit. - Use `warn` for not finding archive reader. - Avoid spurious lint issues when running simtest. ## Test Plan CI https://github.com/MystenLabs/sui/actions/runs/8276357969/job/22644782845 --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Receive the network service IP from the host, instead of specifying it when starting the service. Among other reasons, this helps with binding to the same IP and port after stopping the service in sim tests.
Also,
warnfor not finding archive reader.Test Plan
CI
https://github.com/MystenLabs/sui/actions/runs/8276357969/job/22644782845
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes