indexer: cp sequence number for tx indices query perf #16617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bmwill
approved these changes
Mar 12, 2024
wlmyng
reviewed
Mar 12, 2024
| tx_sequence_number BIGINT NOT NULL, | ||
| -- Object ID in bytes. | ||
| object_id BYTEA NOT NULL, | ||
| PRIMARY KEY(object_id, tx_sequence_number, cp_sequence_number) |
There was a problem hiding this comment.
q: how come some of these tx_ tables have an index, and others don't?
There was a problem hiding this comment.
those indices were added for tx_reader, others count on the primary key.
| sender BYTEA NOT NULL, | ||
| PRIMARY KEY(sender, tx_sequence_number, cp_sequence_number) | ||
| ); | ||
| CREATE INDEX tx_senders_tx_sequence_number_index ON tx_senders (tx_sequence_number ASC, cp_sequence_number ASC); |
There was a problem hiding this comment.
when issuing a query, will we need to include order by cp_sequence_number asc or desc in order to leverage this index on scan or scan backward?
There was a problem hiding this comment.
this index can be used for both forward and backward scans.
https://www.postgresql.org/docs/current/indexes-ordering.html
The index can also be scanned backward ...
in fact, it's a bit verbose here to specify ASC as it's the default one, I will remove it in a following PR I am working on
gegaowp
added a commit
to gegaowp/sui
that referenced
this pull request
Mar 22, 2024
…Labs#16617)" This reverts commit 75afd6c.
gegaowp
added a commit
that referenced
this pull request
Mar 22, 2024
…)"" This reverts commit c47b362.
gegaowp
added a commit
to gegaowp/sui
that referenced
this pull request
Mar 22, 2024
…Labs#16617)" This reverts commit 75afd6c.
gegaowp
added a commit
that referenced
this pull request
Mar 22, 2024
gegaowp
added a commit
to gegaowp/sui
that referenced
this pull request
Mar 25, 2024
…Labs#16617)" This reverts commit 75afd6c.
gegaowp
added a commit
that referenced
this pull request
Mar 25, 2024
…" (#16816) This reverts commit 75afd6c. ## Description This is an indexer breaking change and as a result should not be merged just yet before the corresponding backfill is done. ## Test Plan test on benchmark to make sure that after this revert, the schema is compatible with one before. ## Prevention Plan next time for breaking change, I will add `[NO COMMIT] indexer breaking change` as the prefix. --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
emmazzz
pushed a commit
that referenced
this pull request
Mar 27, 2024
…)"" This reverts commit c47b362.
leecchh
pushed a commit
that referenced
this pull request
Mar 27, 2024
…" (#16816) This reverts commit 75afd6c. ## Description This is an indexer breaking change and as a result should not be merged just yet before the corresponding backfill is done. ## Test Plan test on benchmark to make sure that after this revert, the schema is compatible with one before. ## Prevention Plan next time for breaking change, I will add `[NO COMMIT] indexer breaking change` as the prefix. --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
gegaowp
added a commit
to gegaowp/sui
that referenced
this pull request
Apr 17, 2024
…enLabs#16617)"" This reverts commit c47b362.
gegaowp
added a commit
to gegaowp/sui
that referenced
this pull request
Apr 19, 2024
…enLabs#16617)"" This reverts commit c47b362.
gegaowp
added a commit
to gegaowp/sui
that referenced
this pull request
May 1, 2024
…enLabs#16617)"" This reverts commit c47b362.
gegaowp
added a commit
that referenced
this pull request
May 2, 2024
…)"" This reverts commit c47b362.
amnn
pushed a commit
that referenced
this pull request
May 9, 2024
…)"" This reverts commit c47b362.
tx-tomcat
pushed a commit
to tx-tomcat/sui-network
that referenced
this pull request
May 30, 2024
## Description title also merged the schema files of tx indices for simplicity ## Test Plan local cargo run to make sure that the column can be populated properly --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
title
also merged the schema files of tx indices for simplicity
Test Plan
local cargo run to make sure that the column can be populated properly
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes