Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clean up] - Remove rest server and update docs #1654

Merged
merged 4 commits into from
Apr 29, 2022
Merged

[clean up] - Remove rest server and update docs #1654

merged 4 commits into from
Apr 29, 2022

Conversation

patrickkuo
Copy link
Contributor

No description provided.

@patrickkuo patrickkuo requested a review from Clay-Mysten as a code owner April 28, 2022 17:42
Clay-Mysten
Clay-Mysten approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@Clay-Mysten Clay-Mysten left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, Patrick! I've made small edits inline here and created these PRs to integrate the new page and announce it:
#1662
#1664
#1663

I also announced the change on go/mysten. PTAL. Thanks!

bmwill
bmwill approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@bmwill bmwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love negative diffs!

patrickkuo and others added 4 commits April 29, 2022 00:42
@patrickkuo
Remove rest server and update docs
b455980
@patrickkuo
remove unused deps
b734035
@Clay-Mysten @patrickkuo
Update json-rpc.md
d9b72c8 
Remove eponymous links for future proofing
@Clay-Mysten @patrickkuo
Update wallet.md
f8927d0 
Fix small article disagreement in "a RPC"
@patrickkuo patrickkuo force-pushed the pat/remove_rest_server branch from 3a95ae3 to f8927d0 Compare April 28, 2022 23:43
@patrickkuo patrickkuo merged commit ca9046f into main Apr 29, 2022
@patrickkuo patrickkuo deleted the pat/remove_rest_server branch April 29, 2022 00:23
@Clay-Mysten
Copy link
Contributor

Here is one more, to update the FAQ:
#1671

@Clay-Mysten Clay-Mysten mentioned this pull request Apr 29, 2022
Closed
longbowlu pushed a commit that referenced this pull request May 12, 2022
@patrickkuo @Clay-Mysten @longbowlu
[clean up] - Remove rest server and update docs (#1654)
8624492 
* Remove rest server and update docs

* remove unused deps

* Update json-rpc.md

Remove eponymous links for future proofing

* Update wallet.md

Fix small article disagreement in "a RPC"

Co-authored-by: Clay-Mysten <100217682+Clay-Mysten@users.noreply.github.com>
punwai pushed a commit that referenced this pull request Jul 27, 2022
@patrickkuo @Clay-Mysten @longbowlu
[clean up] - Remove rest server and update docs (#1654)
36adfe5 
* Remove rest server and update docs

* remove unused deps

* Update json-rpc.md

Remove eponymous links for future proofing

* Update wallet.md

Fix small article disagreement in "a RPC"

Co-authored-by: Clay-Mysten <100217682+Clay-Mysten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmwill bmwill bmwill approved these changes

@Clay-Mysten Clay-Mysten Clay-Mysten approved these changes

@awelc awelc Awaiting requested review from awelc

@666lcz 666lcz Awaiting requested review from 666lcz

@oxade oxade Awaiting requested review from oxade

@stella3d stella3d Awaiting requested review from stella3d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickkuo @Clay-Mysten @bmwill