[Faucet] Increase default gas budget #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
666lcz
reviewed
Apr 28, 2022
faucet/src/faucet/simple_faucet.rs
Outdated
| @@ -27,7 +27,7 @@ pub struct SimpleFaucet { | |||
| active_address: SuiAddress, | |||
| } | |||
|
|
|||
| const DEFAULT_GAS_BUDGET: u64 = 1000; | |||
| const DEFAULT_GAS_BUDGET: u64 = 50000; | |||
There was a problem hiding this comment.
This is for paying the transfer operations instead of sending to users. The latter is defined here and configurable in the deployment script. You can change this line to 10000 and it will take effect after the next deployment(let me know if you want a deployment asap)
lxfind
force-pushed
the
increase-default-gas
branch
from
4ef167a to
0df0549
Compare
666lcz
approved these changes
Apr 28, 2022
longbowlu
pushed a commit
that referenced
this pull request
May 12, 2022
punwai
pushed a commit
that referenced
this pull request
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A typical publish can cost 10000 gas. 1000 is likely not enough to do anything meaningful.
Let me know if this is too big.