[Consensus 2.0] propagate errors from Core to upstream #16355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
mwtian
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Nice. I'm thinking of handling errors in the following ways:
- Shutdown: propagate to core thread and shut it down.
- Storage errors: ok to panic at lower level since usually there is no way to retry.
- Client network errors: retry request.
- Peer request validation errors: return error to peers.
- Transaction submission failures: return error to Sui.
Agreed with all the above. Regarding this: |
akichidis
force-pushed
the
akichidis/mysticeti-15
branch
from
45596db to
bf67ad1
Compare
7 tasks
…rantee that the subscribers are live.
tx-tomcat
pushed a commit
to tx-tomcat/sui-network
that referenced
this pull request
May 30, 2024
) ## Description Propagates the errors from Core to upstream components (namely CoreThread) to handle. When the error is a `Shutdown` one then we close the core loop and exit, otherwise we panic as it is deemed a fatal one. Since we are doing this I've also propagated an error from the commit observer to follow a uniform approach. ## Test Plan CI --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Propagates the errors from Core to upstream components (namely CoreThread) to handle. When the error is a
Shutdownone then we close the core loop and exit, otherwise we panic as it is deemed a fatal one. Since we are doing this I've also propagated an error from the commit observer to follow a uniform approach.Test Plan
CI
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes