Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Update recommended cargo version #1630

Merged
merged 1 commit into from
Apr 28, 2022
Merged

[docs] Update recommended cargo version #1630

merged 1 commit into from
Apr 28, 2022

Conversation

theodormarcu
Copy link
Contributor

@theodormarcu theodormarcu commented Apr 27, 2022 •
edited
Loading

Currently, the recommended cargo version for sui is 1.59.0. However, this is no longer applicable since PR #1541, which breaks compatibility with 1.59.0 because of the use of output.stderr.escape_ascii() in sui/build.rs.

This change simply updates the docs to suggest 1.60.0 instead.

This issue affects other users as well. See #1605

@Clay-Mysten
Copy link
Contributor

Note also other cargo install issues noted in:
#1611

@Clay-Mysten Clay-Mysten requested review from awelc, lxfind and 666lcz April 27, 2022 23:42
Clay-Mysten
Clay-Mysten approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@Clay-Mysten Clay-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Theodor. Let's get this change in.

@Clay-Mysten Clay-Mysten enabled auto-merge (squash) April 28, 2022 02:52
@Clay-Mysten Clay-Mysten merged commit 882566f into MystenLabs:main Apr 28, 2022
@kchalkias kchalkias self-requested a review April 28, 2022 03:48
@theodormarcu theodormarcu deleted the theo/update-suggested-cargo-version branch April 28, 2022 21:20
@Clay-Mysten Clay-Mysten mentioned this pull request May 10, 2022
Closed
longbowlu pushed a commit that referenced this pull request May 12, 2022
@theodormarcu @longbowlu
[docs] Update recommended cargo version (#1630)
162b02a
punwai pushed a commit that referenced this pull request Jul 27, 2022
@theodormarcu @longbowlu
[docs] Update recommended cargo version (#1630)
6531bb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clay-Mysten Clay-Mysten Clay-Mysten approved these changes

@bmwill bmwill Awaiting requested review from bmwill

@huitseeker huitseeker Awaiting requested review from huitseeker

@awelc awelc Awaiting requested review from awelc

@lxfind lxfind Awaiting requested review from lxfind

@666lcz 666lcz Awaiting requested review from 666lcz

@kchalkias kchalkias Awaiting requested review from kchalkias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theodormarcu @Clay-Mysten