Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Faucet] Add more configurable parameters #1606

Merged
merged 2 commits into from
Apr 27, 2022
Merged

[Faucet] Add more configurable parameters #1606

merged 2 commits into from
Apr 27, 2022

Conversation

666lcz
Copy link
Contributor

@666lcz 666lcz commented Apr 27, 2022

No description provided.

@666lcz 666lcz requested review from patrickkuo, bmwill and velvia April 27, 2022 08:08
patrickkuo
patrickkuo approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@patrickkuo patrickkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please make sure to update the doc as well for the added configurable args

velvia
velvia reviewed Apr 27, 2022
View reviewed changes
Copy link
Contributor

@velvia velvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request - instead of host can we name the parameter host_ip or listen_ip to emphasize that this has to be an IP address, not a hostname? Thanks.

@666lcz 666lcz force-pushed the chris/faucet-configurable branch from b9b4360 to 8d7b5d4 Compare April 27, 2022 18:23
@666lcz 666lcz enabled auto-merge (squash) April 27, 2022 18:23
@666lcz 666lcz force-pushed the chris/faucet-configurable branch from 8d7b5d4 to 4443e63 Compare April 27, 2022 20:21
@666lcz 666lcz merged commit b3f48ca into main Apr 27, 2022
@666lcz 666lcz deleted the chris/faucet-configurable branch April 27, 2022 20:36
longbowlu pushed a commit that referenced this pull request May 12, 2022
@666lcz @longbowlu
[Faucet] Add more configurable parameters (#1606)
e922f41
punwai pushed a commit that referenced this pull request Jul 27, 2022
@666lcz @longbowlu
[Faucet] Add more configurable parameters (#1606)
b9679f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velvia velvia velvia left review comments

@patrickkuo patrickkuo patrickkuo approved these changes

@bmwill bmwill Awaiting requested review from bmwill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@666lcz @velvia @patrickkuo