move: pause tracking a package in config.toml #16032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
manolisliolios
approved these changes
Jan 31, 2024
tnowacki
approved these changes
Jan 31, 2024
tzakian
approved these changes
Jan 31, 2024
7 tasks
rvantonder
added a commit
that referenced
this pull request
Feb 13, 2024
## Description
As in title. The config now supports specifying multiple branches per
repository:
```toml
[[packages.values.branches]]
branch = "framework/mainnet"
paths = [
{ path = "crates/sui-framework/packages/deepbook", watch = "0xdee9" },
{ path = "crates/sui-framework/packages/move-stdlib", watch = "0x1" },
{ path = "crates/sui-framework/packages/sui-framework", watch = "0x2" },
{ path = "crates/sui-framework/packages/sui-system", watch = "0x3" }
]
[[packages.values.branches]]
# ... more ...
```
Useful for supporting external packages, with this we can now
effectively version sources that implement a bespoke branch naming
scheme for immutable packages (`mainnet-v0`, `mainnet-v1`, etc.) Related
to better supporting external packages, see
#16032
## Test Plan
Updated existing tests to exercise changes (clone commands, finding
branch clone destination)
---
If your changes are not user-facing and do not break anything, you can
skip the following section. Otherwise, please briefly describe what has
changed under the Release Notes section.
### Type of Change (Check all that apply)
- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration
### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The source for this package is moving on the
masterbranch kunalabs-io/sui-smart-contracts@e6fcbd6 which shouldn't happen when we're tracking it for bytecode verification. When it moves, but the published address stays the same, the bytecode no longer matches upstream and the service pauses.I'll get in touch with package maintainers to figure out how we can pin the source to a branch that doesn't move or is being actively developed against, and will then re-enable.
Test Plan
N/A, maintaining source service.
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes