Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphQL/Docs] Documenting Connections, Cursors, Pagination etc. #16020

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

amnn
Copy link
Contributor

@amnn amnn commented Jan 31, 2024

Description

Adding documentation on how Connections work, including cursors, consistency, available range, page limits, and some examples of forward and backward pagination.

Test Plan

docs/site$ pnpm build && pnpm start
  • 👀

Stack

amnn added 2 commits January 31, 2024 01:42
Create distinct top-level headings under "References" for "Sui
JSON-RPC API" and "Sui GraphQL API". This was to avoid a couple of
confusing aspects of the previous IA:

- It was unclear when reading "Sui API" what that was referring
  to (GraphQL or JSON-RPC).
- The "RPC Best Practices" page (intended for JSON-RPC) was
  confusingly next to the GraphQL references.

Test Plan:

```
docs/site$ pnpm build && pnpm start
```

+ 👀
Adding documentation on how Connections work, including cursors,
consistency, available range, page limits, and some examples of
forward and backward pagination.

Test Plan:

```
docs/site$ pnpm build && pnpm start
```
@amnn amnn self-assigned this Jan 31, 2024
Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 3:33am
multisig-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 3:33am
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 3:33am
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 3:33am
sui-kiosk ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 3:33am
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 3:33am

Copy link
Contributor

@stefan-mysten stefan-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, I learned a lot. Thanks @amnn

docs/content/concepts/graphql-rpc/pagination.mdx Outdated Show resolved Hide resolved
docs/content/concepts/graphql-rpc/pagination.mdx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants