-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sequencer number bug #1601
Merged
Merged
Fix sequencer number bug #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
asonnino
commented
Apr 26, 2022
- Fix bug Shared object index initialisation #1600
- Make a unit test to ensure the bug is fixed
lxfind
reviewed
Apr 26, 2022
lxfind
reviewed
Apr 27, 2022
lxfind
approved these changes
Apr 27, 2022
pub fn publish_move_package_transaction(gas_object: Object) -> Transaction { | ||
let build_config = BuildConfig::default(); | ||
let mut path = PathBuf::from(env!("CARGO_MANIFEST_DIR")); | ||
path.push("../sui_programmability/examples/basics"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to make this an argument to make this function more generic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point #974
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
move
Priority: High
Very important task, not blocking but potentially delaying milestones or limiting our offering
Status: Needs Review
PR is ready for review
sui-node
Type: Bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.