[graphql/rpc] crate re-org 1/x: split off client crate #15571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
oxade
requested review from
amnn,
wlmyng,
stefan-mysten,
emmazzz and
suiwombat
as code owners
wlmyng
approved these changes
Jan 5, 2024
| sui-graphql-rpc-headers.workspace = true | ||
| sui-graphql-rpc-client.workspace = true | ||
|
|
||
|
|
amnn
reviewed
Jan 6, 2024
| @@ -1,7 +1,7 @@ | |||
| // Copyright (c) Mysten Labs, Inc. | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| pub mod client; | |||
| pub use sui_graphql_rpc_client as client; | |||
There was a problem hiding this comment.
Do we still need this? It seems counter-intuitive to export the client from the server if we're splitting it out into its own crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split off the client crate so importing it is lighter.
Other useful components will be split off too in subseq PRs.
Test Plan
Existing
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes