Derive narwhal ports from sui #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mystenmark Is this compatible with your devnet setup? |
asonnino
added
Type: Major Feature
mystenmark
reviewed
Apr 21, 2022
| .parse() | ||
| .unwrap(), | ||
| transactions: x.consensus_address, | ||
| worker_to_worker: format!("{}:{}", x.host, x.port + 4).parse().unwrap(), |
There was a problem hiding this comment.
ok, so its just using the next 4 ports above the validator port?
There was a problem hiding this comment.
plus the tx-input port (that was already present in the AuthorityPrivateConfig struct)
|
This is great and saves me the work of manually fixing up the narwhal config. Thanks! |
mystenmark
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The narwhal node need a committee file, it is now derived from the Sui committee file. The narwhal primary and workers already bind to 0.0.0.0: https://github.com/MystenLabs/narwhal/blob/6788cf3da00b94b72a9dcc16e9da199e18ba6e37/primary/src/primary.rs#L142