[framework] Adds TokenPolicyCreated event to the token module #15128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
amnn
approved these changes
Nov 30, 2023
| @@ -250,7 +250,7 @@ | |||
| ] | |||
| }, | |||
| "32": { | |||
| "git_revision": "bdbc732269", | |||
| "git_revision": "f918308973-dirty", | |||
There was a problem hiding this comment.
Technically, this revision should be the new (clean) revision in the release branch, which means you would need to:
- Put the change out in
mainfor review. - Once accepted, create a cherry-pick on the relevant release branch and land it there.
- Create a snapshot in the release branch.
- Copy that into the PR on
main, and land tomain.
But if this works, it works.
There was a problem hiding this comment.
@amnn We don't need any cherry-picks for this, since the branch cut is scheduled for tomorrow for the v1.15.0 release scheduled to go out on 12/13
damirka
force-pushed
the
ds/adds-event-to-token
branch
from
b5f8349 to
63c6f52
Compare
damirka
force-pushed
the
ds/adds-event-to-token
branch
from
63c6f52 to
0ac6c81
Compare
damirka
force-pushed
the
ds/adds-event-to-token
branch
from
3f908e4 to
bd94770
Compare
amnn
force-pushed
the
ds/adds-event-to-token
branch
from
d02fd78 to
83e0312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a simple event emitted when a Policy is shared (or frozen - in the future).
Test Plan
It's just an event.
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes