[Deepbook] Adding empty return to list_open_orders #14940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
healthydeve
force-pushed
the
jlu/filter_db
branch
from
a461b6a to
2b3eddd
Compare
tzakian
pushed a commit
that referenced
this pull request
Nov 29, 2023
## Description Previous `list_open_orders` function crashes on empty attempting to borrow from a df that does not exist. <img width="1327" alt="image" src="https://github.com/MystenLabs/sui/assets/123408603/f1cc8b2b-e9cf-4b76-ab4c-a090bedd0807"> This PR adds an error check and a test to ensure that this will not fail with error, but instead return an empty vector. Also this includes an accessor function to usr_open_orders so other contracts can call this to check user positions ## Test Plan How did you test the new or updated feature? unit test --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous
list_open_ordersfunction crashes on empty attempting to borrow from a df that does not exist.This PR adds an error check and a test to ensure that this will not fail with error, but instead return an empty vector.
Also this includes an accessor function to usr_open_orders so other contracts can call this to check user positions
Test Plan
How did you test the new or updated feature?
unit test
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes