[deepbook] - make critbit tree and order getters public #14927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
patrickkuo
force-pushed
the
pat/deep-book-getters
branch
from
f9f937a to
9521e70
Compare
patrickkuo
force-pushed
the
pat/deep-book-getters
branch
from
5e0d90d to
24ea663
Compare
|
We also need to run the test generation under |
patrickkuo
force-pushed
the
pat/deep-book-getters
branch
from
24ea663 to
02065dc
Compare
healthydeve
approved these changes
Nov 21, 2023
| @@ -1858,27 +1858,43 @@ module deepbook::clob_v2 { | |||
| } | |||
|
|
|||
| // Methods for accessing pool data, used by the order_query package | |||
| public(friend) fun asks<BaseAsset, QuoteAsset>(pool: &Pool<BaseAsset, QuoteAsset>): &CritbitTree<TickLevel> { | |||
There was a problem hiding this comment.
Do we know if changing these functions have backwards compatibility issues? cc: @sblackshear @amnn
There was a problem hiding this comment.
It's fine to make these public (and not public(friend)), but it does mean that in future, you will have to preserve the signature of this function.
tzakian
pushed a commit
that referenced
this pull request
Nov 29, 2023
## Description Make critbit tree and order getters public ## Test Plan There are no logic changes, rely on existing unit tests. --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make critbit tree and order getters public
Test Plan
There are no logic changes, rely on existing unit tests.
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes