Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the rest of the source conditions #14889

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

Jordan-Mysten
Copy link
Contributor

Description

Describe the changes or additions included in this PR.

Test Plan

How did you test the new or updated feature?


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 10:55pm
multisig-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 10:55pm
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 10:55pm
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 10:55pm
sui-kiosk ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 10:55pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 10:55pm

Copy link
Contributor

github-actions bot commented Nov 16, 2023

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the Sui repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

@Jordan-Mysten Jordan-Mysten force-pushed the jordan--remove-remaining-source-conditions branch from 1b7695f to 3ab33f1 Compare November 16, 2023 22:48
@Jordan-Mysten Jordan-Mysten merged commit 299759d into main Nov 17, 2023
34 of 36 checks passed
@Jordan-Mysten Jordan-Mysten deleted the jordan--remove-remaining-source-conditions branch November 17, 2023 00:00
ebmifa pushed a commit that referenced this pull request Nov 20, 2023
## Description 

Describe the changes or additions included in this PR.

## Test Plan 

How did you test the new or updated feature?

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants