Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dapps, closed loop] Adds regulated token cli #14711

Merged
merged 2 commits into from
Nov 7, 2023
Merged

[dapps, closed loop] Adds regulated token cli #14711

merged 2 commits into from
Nov 7, 2023

Conversation

damirka
Copy link
Contributor

@damirka damirka commented Nov 7, 2023

Description

Adds a dapp-example for a CLI application.

Test Plan

How did you test the new or updated feature?


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@damirka damirka self-assigned this Nov 7, 2023
@damirka damirka requested a review from ronny-mysten as a code owner November 7, 2023 20:25
Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 10:23pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 10:23pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2023 10:23pm
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2023 10:23pm
mysten-ui ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2023 10:23pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2023 10:23pm

/// it is changed to the "recipient". This field is future-proofing for
/// the "Transfer To Object" (TTO) feature, making it impossible to send
/// a `Token` to an object and do arbitrary transfers through it.
owner: address,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tzakian shared some good news with me: we are changing the way TTO works so this will no longer be needed!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm keeping it for now to speed things up and will remove in the framework PR.

@damirka damirka enabled auto-merge (squash) November 7, 2023 22:24
@damirka damirka merged commit 4e2c66c into main Nov 7, 2023
37 checks passed
@damirka damirka deleted the ds/token-cli branch November 7, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants