-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[formal snapshots] Support without DB Checkpoint upload #14645
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
williampsmith
force-pushed
the
support-db-checkpoint-without-upload
branch
from
November 3, 2023 22:58
c87accb
to
f8e0010
Compare
williampsmith
force-pushed
the
support-db-checkpoint-without-upload
branch
from
November 3, 2023 23:23
f8e0010
to
346ba76
Compare
williampsmith
changed the title
Support DB Checkpoint without upload
[formal snapshots] Support without DB Checkpoint upload
Nov 3, 2023
williampsmith
force-pushed
the
support-db-checkpoint-without-upload
branch
from
November 7, 2023 01:03
346ba76
to
2fdb180
Compare
sadhansood
reviewed
Nov 10, 2023
williampsmith
force-pushed
the
support-db-checkpoint-without-upload
branch
from
November 10, 2023 00:11
2fdb180
to
9bb8a07
Compare
williampsmith
force-pushed
the
support-db-checkpoint-without-upload
branch
from
November 10, 2023 00:13
9bb8a07
to
09cbe3c
Compare
williampsmith
force-pushed
the
support-db-checkpoint-without-upload
branch
from
November 10, 2023 00:15
09cbe3c
to
b59cae4
Compare
sadhansood
approved these changes
Nov 10, 2023
williampsmith
force-pushed
the
support-db-checkpoint-without-upload
branch
from
November 10, 2023 01:18
b59cae4
to
7b7d5af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today in order for formal snapshots to work, we also need to enable full db checkpoint config, including providing an object store and awaiting upload. Some node operators may want to only upload formal snapshots without incurring the cost of also uploading and maintaining a db checkpoint snapshot. Moreover, we will eventually move to only supporting formal snapshots. This PR introduces the capability to configure a node to generate and upload formal snapshots (state snapshots) without the need to also upload db checkpoints. We do this by generating a minimal db checkpoint config for use by
DBCheckpointHandler
and introducing a separate loop path in the handler, which simply marks new db checkpoints withUPLOAD_COMPLETED
marker so that they can be used for formal snapshots and subsequently gc'ed.Test Plan
Ran locally for 5 epochs with the following relevant config
and with no db checkpoint config.
Observed snapshots being geenerated:
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes