Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet-ext] - add Banxa as onramp provider #14440

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

mamos-mysten
Copy link
Contributor

@mamos-mysten mamos-mysten commented Oct 25, 2023

Description

  • Adds Banxa as an onramp provider.
  • Updates the UI to match the latest spec.

Test Plan

How did you test the new or updated feature?


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 6:31pm
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 6:31pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 6:31pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 6:31pm
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 6:31pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 6:31pm

@vercel vercel bot temporarily deployed to Preview – mysten-ui October 25, 2023 23:00 Inactive
@vercel vercel bot temporarily deployed to Preview – mysten-ui November 3, 2023 16:32 Inactive
@vercel vercel bot temporarily deployed to Preview – mysten-ui November 6, 2023 21:27 Inactive
@vercel vercel bot temporarily deployed to Preview – mysten-ui November 13, 2023 21:22 Inactive
@vercel vercel bot temporarily deployed to Preview – mysten-ui November 14, 2023 23:19 Inactive
"resources": ["dapp-interface.js"],
"matches": ["<all_urls>"]
"resources": ["ui.html"],
"matches": ["https://*.banxa.com/*"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this allows Banxa to redirect back to the wallet

Copy link
Contributor

@pchrysochoidis pchrysochoidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one small comment

@vercel vercel bot temporarily deployed to Preview – mysten-ui November 21, 2023 18:31 Inactive
@mamos-mysten mamos-mysten merged commit 69c4cd1 into main Nov 21, 2023
@mamos-mysten mamos-mysten deleted the mamos--cb-onramp branch November 21, 2023 18:46
tzakian pushed a commit that referenced this pull request Nov 29, 2023
## Description 

- Adds Banxa as an onramp provider. 
- Updates the UI to match the latest spec.

## Test Plan 

How did you test the new or updated feature?

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants