Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/easy: ord clippy lint #14356

Merged
merged 1 commit into from
Oct 20, 2023
Merged

chore/easy: ord clippy lint #14356

merged 1 commit into from
Oct 20, 2023

Conversation

oxade
Copy link
Contributor

@oxade oxade commented Oct 20, 2023

Description

This is the last cleanup for the outstanding lints from #14167
In order to preserve existing behavior, it was easier to selectively ignore the lints on specific files.

Test Plan

Existing

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
mysten-ui ✅ Ready (Inspect) Visit Preview Oct 20, 2023 4:31pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview Oct 20, 2023 4:31pm
3 Ignored Deployments
Name Status Preview Updated (UTC)
explorer ⬜️ Ignored (Inspect) Oct 20, 2023 4:31pm
multisig-toolkit ⬜️ Ignored (Inspect) Oct 20, 2023 4:31pm
sui-kiosk ⬜️ Ignored (Inspect) Oct 20, 2023 4:31pm

@tzakian
Copy link
Contributor

tzakian commented Oct 20, 2023

Lgtm

@oxade oxade merged commit 2cb0421 into main Oct 20, 2023
32 checks passed
@oxade oxade deleted the move-clippy-pt3 branch October 20, 2023 18:48
jonas-lj pushed a commit to jonas-lj/sui that referenced this pull request Nov 2, 2023
## Description 

This is the last cleanup for the outstanding lints from
MystenLabs#14167
In order to preserve existing behavior, it was easier to selectively
ignore the lints on specific files.

## Test Plan 

Existing
---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants