Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/easy: fix some clippy lints in move #14352

Merged
merged 1 commit into from
Oct 19, 2023
Merged

chore/easy: fix some clippy lints in move #14352

merged 1 commit into from
Oct 19, 2023

Conversation

oxade
Copy link
Contributor

@oxade oxade commented Oct 19, 2023

Description

Fixes some clippy lints ignored when this PR was inteoduced.
Others coming shortly.

Test Plan

Existing


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
mysten-ui ✅ Ready (Inspect) Visit Preview Oct 19, 2023 7:39pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview Oct 19, 2023 7:39pm
3 Ignored Deployments
Name Status Preview Updated (UTC)
explorer ⬜️ Ignored (Inspect) Oct 19, 2023 7:39pm
multisig-toolkit ⬜️ Ignored (Inspect) Oct 19, 2023 7:39pm
sui-kiosk ⬜️ Ignored (Inspect) Oct 19, 2023 7:39pm

Copy link
Contributor

@cgswords cgswords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great.

@oxade oxade enabled auto-merge (squash) October 19, 2023 19:45
@oxade oxade merged commit 8059c44 into main Oct 19, 2023
@oxade oxade deleted the chore-move-clippy branch October 19, 2023 19:57
jonas-lj pushed a commit to jonas-lj/sui that referenced this pull request Nov 2, 2023
## Description 

Fixes some clippy lints ignored when
[this](MystenLabs#14167) PR was inteoduced.
Others coming shortly.

## Test Plan 

Existing

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants