Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not-ready links in index.md, fix a bug in chapter 1 #1332

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Apr 12, 2022

Links that are not ready probably shouldn't be linked in index, because it can be confusing.
Also fix a bug in the chapter 1 command.

@lxfind lxfind added the Type: Documentation Improvements or additions to documentation label Apr 12, 2022
@lxfind lxfind requested a review from kyleqian April 12, 2022 20:34
@lxfind lxfind requested a review from Clay-Mysten as a code owner April 12, 2022 20:34
Copy link
Contributor

@Clay-Mysten Clay-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Xun!

Copy link
Contributor

@Clay-Mysten Clay-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking care of this in:
#1338

@lxfind lxfind enabled auto-merge (squash) April 13, 2022 00:28
@lxfind lxfind merged commit 76cde01 into main Apr 13, 2022
@lxfind lxfind deleted the fix-ch1 branch April 13, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants