Remove unused NW code now that we moved past V11 #13169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
arun-koshy
force-pushed
the
ak/remove-unused-nw
branch
from
a14b001 to
d5eaec6
Compare
mwtian
approved these changes
Jul 27, 2023
ebmifa
pushed a commit
that referenced
this pull request
Aug 10, 2023
## Description We have moved past protocol version 11 so we can remove some of the unused code. However because Batch store expects the original Batch enum format we cannot remove BatchV1 completely without causing issues to the schema. To fully remove BatchV1 we will have to create a new Batch store that only uses BatchV2 instead of the Batch versioned enum. ## Test Plan [Tested version upgrade in labnet](https://metrics.sui.io/d/HH91BjB4z/throughput?orgId=1&from=1690435970447&to=1690437139251&var-Environment=mysten-metrics-internal&var-network=labnet&var-validator=All)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have moved past protocol version 11 so we can remove some of the unused code. However because Batch store expects the original Batch enum format we cannot remove BatchV1 completely without causing issues to the schema. To fully remove BatchV1 we will have to create a new Batch store that only uses BatchV2 instead of the Batch versioned enum.
Test Plan
Tested version upgrade in labnet