Fix sui-node binary placement in Docker
#13139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
|
@mwtian Did you download the newly built docker image and see if you can run it locally successfully? |
|
@ebmifa yes I did run |
arun-koshy
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
edit: aah I was using a docker image built specifically for linux, where can I find the docker images and one built for mac?
Is this only for linux? I tried running on my mac just out of curiosity
sudo docker run mysten/sui-node:1112c07c573bb54b3a83a83b514d834451a73329 /usr/local/bin/sui-node --version
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
sui-node 1.7.0-1112c07c5
|
You can use add a |
ebmifa
pushed a commit
that referenced
this pull request
Aug 10, 2023
## Description Fix `sui-node` Dockerfile cleanup, by adding back `sui-node` at `/usr/local/bin/sui-node`. ## Test Plan CI https://github.com/MystenLabs/sui-operations/actions/runs/5653096771 `sudo docker run mysten/sui-node:1112c07c573bb54b3a83a83b514d834451a73329 /usr/local/bin/sui-node --version` --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
sui-nodeDockerfile cleanup, by adding backsui-nodeat/usr/local/bin/sui-node.Test Plan
CI
https://github.com/MystenLabs/sui-operations/actions/runs/5653096771
sudo docker run mysten/sui-node:1112c07c573bb54b3a83a83b514d834451a73329 /usr/local/bin/sui-node --versionIf your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes