-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wallet CLI] use --no-shell by default #1311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@@ -25,14 +25,14 @@ const SUI: &str = " _____ _ _ __ ____ __ | |||
|
|||
#[derive(StructOpt)] | |||
#[structopt( | |||
name = "Sui Demo Wallet", | |||
name = "wallet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this no longer a demo wallet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this name will display in the help - usage section, it looks incorrect with the full name
e.g.
USAGE: Sui Demo Wallet [FLAGS] [OPTIONS] [SUBCOMMAND]
vs
USAGE: wallet [FLAGS] [OPTIONS] [SUBCOMMAND]
Codecov Report
@@ Coverage Diff @@
## main #1311 +/- ##
==========================================
+ Coverage 81.70% 81.77% +0.07%
==========================================
Files 99 99
Lines 20766 20766
==========================================
+ Hits 16966 16982 +16
+ Misses 3800 3784 -16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of tutorials.md, as well as wallet.md, Patrick!
wallet cli now default to cli mode (no-shell)
added
-i
flag for interactive modeAlso updated command snippets in docs for this changes