Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet CLI] use --no-shell by default #1311

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Conversation

patrickkuo
Copy link
Contributor

@patrickkuo patrickkuo commented Apr 11, 2022

wallet cli now default to cli mode (no-shell)
added -i flag for interactive mode

Also updated command snippets in docs for this changes

@patrickkuo patrickkuo self-assigned this Apr 11, 2022
@patrickkuo patrickkuo requested a review from Clay-Mysten as a code owner April 11, 2022 01:10
@patrickkuo patrickkuo linked an issue Apr 11, 2022 that may be closed by this pull request
Copy link
Contributor

@lxfind lxfind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@@ -25,14 +25,14 @@ const SUI: &str = " _____ _ _ __ ____ __

#[derive(StructOpt)]
#[structopt(
name = "Sui Demo Wallet",
name = "wallet",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this no longer a demo wallet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this name will display in the help - usage section, it looks incorrect with the full name
e.g.
USAGE: Sui Demo Wallet [FLAGS] [OPTIONS] [SUBCOMMAND]
vs
USAGE: wallet [FLAGS] [OPTIONS] [SUBCOMMAND]

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1311 (5107d5d) into main (e615cda) will increase coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1311      +/-   ##
==========================================
+ Coverage   81.70%   81.77%   +0.07%     
==========================================
  Files          99       99              
  Lines       20766    20766              
==========================================
+ Hits        16966    16982      +16     
+ Misses       3800     3784      -16     
Impacted Files Coverage Δ
sui/src/wallet.rs 0.98% <0.00%> (ø)
sui/src/wallet_commands.rs 83.00% <0.00%> (-0.22%) ⬇️
...ammability/adapter/src/unit_tests/adapter_tests.rs 98.55% <0.00%> (+0.10%) ⬆️
sui_types/src/object.rs 81.74% <0.00%> (+0.25%) ⬆️
sui_core/src/authority_aggregator.rs 87.31% <0.00%> (+0.60%) ⬆️
sui_core/src/safe_client.rs 60.00% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e615cda...5107d5d. Read the comment docs.

@patrickkuo patrickkuo merged commit 0928366 into main Apr 11, 2022
@patrickkuo patrickkuo deleted the pat/wallet_default_no_shell branch April 11, 2022 09:43
Copy link
Contributor

@Clay-Mysten Clay-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of tutorials.md, as well as wallet.md, Patrick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wallet CLI] use --no-shell by default
4 participants