Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses yarn resolutions to force a higher version of node-notifier #1295

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

apburnie
Copy link
Contributor

@apburnie apburnie commented Apr 8, 2022

This issues a fix to the TypeScript SDK to resolve the Dependabot errors.

I've added a resolutions field to the package.json to force an upgrade of node-notifier, following guidance from karlhorky here:
jaredpalmer/tsdx#949

This does not seem to break the running of TSDX.

Would it be possible to run Dependabot on this branch to see if it solves the problem?

@apburnie apburnie requested review from huitseeker and 666lcz April 8, 2022 13:08
@apburnie
Copy link
Contributor Author

apburnie commented Apr 8, 2022

Running yarn audit led to the below result:

image

Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, but @666lcz should probably have a look

@666lcz
Copy link
Contributor

666lcz commented Apr 8, 2022

Thank you so much for the investigation and the fix @Andrew47 !

@apburnie apburnie merged commit 544e4e3 into main Apr 8, 2022
@apburnie apburnie deleted the node-notifier-fix branch April 8, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants