[sui-execution] Fully automate making a cut #12882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amnn
requested review from
rvantonder,
awelc,
tnowacki,
tzakian,
oxade,
dariorussi and
wlmyng
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Ignored Deployments
|
dariorussi
approved these changes
Jul 7, 2023
amnn
force-pushed
the
amnn/exec-layer-python
branch
from
1b963a8 to
628024b
Compare
amnn
force-pushed
the
amnn/exec-layer-lib-gen
branch
2 times, most recently
from
1e50f37 to
151c22d
Compare
amnn
force-pushed
the
amnn/exec-layer-python
branch
from
628024b to
1c456a7
Compare
Subsume the manual portion of making a cut (creating implementations of the `Executor` and `Verifier` traits, and hooking them into the dispatch module) into the script: Test Plan: ``` sui$ ./scripts/execution-layer cut v1 sui-execution$ cargo build ``` Also stress test by making 10 cuts, running a clean build and an incremental build to make sure there isn't a measurable effect on builds (there is not).
amnn
force-pushed
the
amnn/exec-layer-lib-gen
branch
from
151c22d to
2ea1e94
Compare
ebmifa
pushed a commit
that referenced
this pull request
Jul 12, 2023
## Description Subsume the manual portion of making a cut (creating implementations of the `Executor` and `Verifier` traits, and hooking them into the dispatch module) into the script: ## Test Plan ``` sui$ ./scripts/execution-layer cut v1 sui-execution$ cargo build ``` Also stress test by making 10 cuts, running a clean build and an incremental build to confirm there isn't a measurable effect on builds (there is not). --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Subsume the manual portion of making a cut (creating implementations of the
ExecutorandVerifiertraits, and hooking them into the dispatch module) into the script:Test Plan
Also stress test by making 10 cuts, running a clean build and an incremental build to confirm there isn't a measurable effect on builds (there is not).
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes