Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet-ext] bullshark modal followups #12879

Merged
merged 10 commits into from
Jul 7, 2023
Merged

Conversation

Nikhil-Mysten
Copy link
Contributor

Description

some behavior changes

Test Plan

Locally


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@Nikhil-Mysten Nikhil-Mysten requested a review from a team as a code owner July 7, 2023 14:30
@Nikhil-Mysten Nikhil-Mysten requested review from Jibz-Mysten, plam-ml, williamrobertson13 and a team and removed request for a team July 7, 2023 14:30
@vercel
Copy link

vercel bot commented Jul 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Jul 7, 2023 4:31pm
explorer-storybook ⬜️ Ignored (Inspect) Jul 7, 2023 4:31pm
multisig-toolkit ⬜️ Ignored (Inspect) Jul 7, 2023 4:31pm
sui-kiosk ⬜️ Ignored (Inspect) Jul 7, 2023 4:31pm
sui-wallet-kit ⬜️ Ignored (Inspect) Jul 7, 2023 4:31pm
wallet-adapter ⬜️ Ignored (Inspect) Jul 7, 2023 4:31pm

Copy link
Contributor

@williamrobertson13 williamrobertson13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@williamrobertson13 williamrobertson13 merged commit c35c0d9 into main Jul 7, 2023
@williamrobertson13 williamrobertson13 deleted the nm/bs-modal-followups branch July 7, 2023 16:49
ebmifa pushed a commit that referenced this pull request Jul 12, 2023
## Description 

some behavior changes

## Test Plan 

Locally

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes

---------

Co-authored-by: William Robertson <williamrobertson@mystenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants