[transactional-tests] Publish correct framework based on protocol version in the transactional test runner #12867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion in transaction test runner.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Ignored Deployments
|
amnn
approved these changes
Jul 7, 2023
tnowacki
reviewed
Jul 7, 2023
ebmifa
pushed a commit
that referenced
this pull request
Jul 12, 2023
…sion in the transactional test runner (#12867)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously when you specified a specific protocol version in a transactional test this wouldn't change or select the correct framework for that protocol version. This now fetches the correct framework objects based on the protocol version from the framework snapshots.
Test Plan
Make sure existing tests still pass, and that the tests that were failing because of this in the transfer-to-object PR are passing.