Use delete_range instead of clear() to avoid race condition #12855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Ignored Deployments
|
sadhansood
approved these changes
Jul 6, 2023
| .next() | ||
| { | ||
| let mut batch = self.locally_computed_checkpoints.batch(); | ||
| batch.delete_range(&self.locally_computed_checkpoints, &0, &last_local_summary)?; |
There was a problem hiding this comment.
This makes sense, we also have ignore_range_delete set to true by default, so we shouldn't see any performance impact on the read side from it.
|
Ah interesting. |
Yeah sure, we can do that. I'll send out a follow up PR. |
ebmifa
pushed a commit
that referenced
this pull request
Jul 12, 2023
because clear() drops and re-creates the table without holding a lock, it can cause crashes if other threads happen to try to write to or read from the table being cleared. I don't think it makes sense to add locking to every DBMap access just to fix this case, so I'm just going to avoid calling clear().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because clear() drops and re-creates the table without holding a lock, it can cause crashes if other threads happen to try to write to or read from the table being cleared. I don't think it makes sense to add locking to every DBMap access just to fix this case, so I'm just going to avoid calling clear().