Track live object set size during expensive checks #12846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Ignored Deployments
|
williampsmith
approved these changes
Jul 5, 2023
mystenmark
reviewed
Jul 5, 2023
| pending_objects.push(object); | ||
| size += match &object.data { | ||
| Data::Move(move_obj) => move_obj.contents().len(), | ||
| Data::Package(move_pkg) => move_pkg.size(), |
There was a problem hiding this comment.
is this the same size that is used for storage cost computation? also this doesn't count coins, does it?
There was a problem hiding this comment.
nevermind on the coins, i remembered that the coin storage format is converted to a move object when being loaded
There was a problem hiding this comment.
Yes, for package the storage cost is determined based on this function object_size_for_gas_metering which literally calls .size() for move_pkg. I think I could just call object_size_for_gas_metering on the object itself which makes it even simpler
sadhansood
force-pushed
the
sadhan/live_object_set_size
branch
from
23a6b03 to
e0aaf28
Compare
sadhansood
force-pushed
the
sadhan/live_object_set_size
branch
from
e0aaf28 to
8a9fc6e
Compare
ebmifa
pushed a commit
that referenced
this pull request
Jul 12, 2023
## Description We would like to track the application level object set size vs db level object set size (which we already have from rocksdb metrics i.e. objects + indirect objects sst table size). Adding this as a part of the expensive checks. ## Test Plan Existing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We would like to track the application level object set size vs db level object set size (which we already have from rocksdb metrics i.e. objects + indirect objects sst table size).
Adding this as a part of the expensive checks.
Test Plan
Existing tests