chore: reorder protocol version 17, 18 #12839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Ignored Deployments
|
mystenmark
reviewed
Jul 5, 2023
| @@ -1288,7 +1288,7 @@ impl ProtocolConfig { | |||
| } | |||
| 17 => { | |||
| let mut cfg = Self::get_for_version_impl(version - 1, chain); | |||
| cfg.execution_version = Some(1); | |||
| cfg.feature_flags.upgraded_multisig_supported = true; | |||
|
|
|||
| // Following flags are implied by this execution version. Once support for earlier | |||
| // protocol versions is dropped, these flags can be removed: | |||
There was a problem hiding this comment.
i think these comments need to follow execution_version or they will not make any sense
mystenmark
approved these changes
Jul 5, 2023
longbowlu
pushed a commit
that referenced
this pull request
Jul 6, 2023
## Description to match with #12837, execution_version will go out with v18 (in 1.5.0) whereas the multisig feature flag will be released with 1.4.2 in v17. ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
ebmifa
pushed a commit
that referenced
this pull request
Jul 12, 2023
## Description to match with #12837, execution_version will go out with v18 (in 1.5.0) whereas the multisig feature flag will be released with 1.4.2 in v17. ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
to match with #12837, execution_version will go out with v18 (in 1.5.0) whereas the multisig feature flag will be released with 1.4.2 in v17.
Test Plan
How did you test the new or updated feature?
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes