[Deepbook] Support creating customized pool #12819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Ignored Deployments
|
|
@wiggins-dev is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
wiggins-dev
force-pushed
the
customized_create_pool
branch
from
5f53240 to
5eb9b79
Compare
wiggins-dev
added a commit
to wiggins-dev/sui
that referenced
this pull request
Jul 3, 2023
## Description Add entry function for creating pool with customized taker fee rete and maker rebate rate. No extra test needed since it is just a simple wrapper function. ## Test Plan cd to deepbook dir and run "sui move test" --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [✅] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [✅] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ---------
wiggins-dev
changed the title
healthydeve
reviewed
Jul 4, 2023
| } | ||
|
|
||
| // Function for creating pool with customized taker fee rate and maker rebate rate. | ||
| // The taker_fee_rate should be greater than or equal to the maker_rebate_rate, and both should have a scaling of 10^9. |
There was a problem hiding this comment.
should we assert this? Also ok if you don't since people just won't use the pool
There was a problem hiding this comment.
We have asserted this inside the internal function "create_pool_".
## Description Add entry function for creating pool with customized taker fee rete and maker rebate rate. No extra test needed since it is just a simple wrapper function. ## Test Plan cd to deepbook dir and run "sui move test" --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [✅] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [✅] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ---------
healthydeve
pushed a commit
to wiggins-dev/sui
that referenced
this pull request
Jul 5, 2023
Add entry function for creating pool with customized taker fee rete and maker rebate rate. No extra test needed since it is just a simple wrapper function. cd to deepbook dir and run "sui move test" --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. - [✅] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [✅] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ---------
healthydeve
force-pushed
the
customized_create_pool
branch
from
5eb9b79 to
f682bed
Compare
wiggins-dev
force-pushed
the
customized_create_pool
branch
from
0bec9fc to
c96e215
Compare
longbowlu
pushed a commit
that referenced
this pull request
Jul 6, 2023
## Description Add entry function for creating pool with customized taker fee rete and maker rebate rate. No extra test needed since it is just a simple wrapper function. ## Test Plan Run deepbook unit test. --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [✅] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [✅] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
wiggins-dev
pushed a commit
to wiggins-dev/sui
that referenced
this pull request
Jul 8, 2023
## Description Update market ask order with quantity. Currently the quantity argument in place_market_order only used for bid side and we sell all the passed in base asset instead the quantity of base asset. To avoid confusing, we now also sell the quantity of base asset. ## Test Plan cd to deepbook dir and run "sui move test" --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [✅] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [✅] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ---------
wiggins-dev
pushed a commit
to wiggins-dev/sui
that referenced
this pull request
Jul 8, 2023
## Description Update market ask order with quantity. Currently the quantity argument in place_market_order only used for bid side and we sell all the passed in base asset instead the quantity of base asset. To avoid confusing, we now also sell the quantity of base asset. ## Test Plan cd to deepbook dir and run "sui move test" --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [✅] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [✅] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ---------
ebmifa
pushed a commit
that referenced
this pull request
Jul 12, 2023
## Description Add entry function for creating pool with customized taker fee rete and maker rebate rate. No extra test needed since it is just a simple wrapper function. ## Test Plan Run deepbook unit test. --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [✅] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [✅] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add entry function for creating pool with customized taker fee rete and maker rebate rate.
No extra test needed since it is just a simple wrapper function.
Test Plan
Run deepbook unit test.
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes