Update faucet API to support batching, and separate into it's own export #12808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan-Mysten
requested review from
Jibz-Mysten and
plam-ml
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jibz-Mysten
approved these changes
Jun 30, 2023
healthydeve
approved these changes
Jun 30, 2023
healthydeve
reviewed
Jun 30, 2023
| @@ -42,6 +42,11 @@ | |||
| "source": "./src/keypairs/secp256r1/index.ts", | |||
| "import": "./dist/esm/keypairs/secp256r1/index.js", | |||
| "require": "./dist/cjs/keypairs/secp256r1/index.js" | |||
| }, | |||
There was a problem hiding this comment.
Noting to myself that this is how you add a new package
There was a problem hiding this comment.
This isn’t a package it’s just a way to more granularly import out of the package. It’s an approach we’re trying to take to minimize the required size of the SDK.
plam-ml
approved these changes
Jun 30, 2023
hayes
reviewed
Jul 1, 2023
Jordan-Mysten
force-pushed
the
jordan--faucet-api-update
branch
from
fce6427 to
310a310
Compare
Jordan-Mysten
force-pushed
the
jordan--faucet-api-update
branch
from
310a310 to
10ecd37
Compare
hayes-mysten
approved these changes
Jul 5, 2023
ebmifa
pushed a commit
that referenced
this pull request
Jul 12, 2023
…ort (#12808) ## Description This is a replacement for #12668, updating all of the faucet APIs to a new export so that it can be used on it's own. The provider and signer methods are now marked as deprecated, and will be removed in a subsequent release. ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a replacement for #12668, updating all of the faucet APIs to a new export so that it can be used on it's own. The provider and signer methods are now marked as deprecated, and will be removed in a subsequent release.
Test Plan
How did you test the new or updated feature?
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes