Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easy] fix name clobbering #12790

Merged
merged 1 commit into from
Jul 5, 2023
Merged

[easy] fix name clobbering #12790

merged 1 commit into from
Jul 5, 2023

Conversation

oxade
Copy link
Contributor

@oxade oxade commented Jun 30, 2023

Description

The short function name was being used as the internal frame identifier, however different functions can have the same short name which can cause clobbering.
For example a::b::add and q::w::add would've both resolved to add. This would mess up the statistics.
PR changes frame identifier to use the unique fully qualified name.

Also cleanup unnecessary drop restructure and constants

Test Plan

Manual


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@oxade oxade requested review from tnowacki, tzakian and dariorussi June 30, 2023 01:25
@vercel
Copy link

vercel bot commented Jun 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Ignored Deployments
Name Status Preview Updated (UTC)
explorer ⬜️ Ignored (Inspect) Jun 30, 2023 1:25am
explorer-storybook ⬜️ Ignored (Inspect) Jun 30, 2023 1:25am
multisig-toolkit ⬜️ Ignored (Inspect) Jun 30, 2023 1:25am
sui-kiosk ⬜️ Ignored (Inspect) Jun 30, 2023 1:25am
sui-wallet-kit ⬜️ Ignored (Inspect) Jun 30, 2023 1:25am
wallet-adapter ⬜️ Ignored (Inspect) Jun 30, 2023 1:25am

@oxade oxade changed the title fix name clobbering [easy] fix name clobbering Jun 30, 2023
@oxade oxade enabled auto-merge (squash) July 2, 2023 05:21
@oxade oxade merged commit 2bc00ef into main Jul 5, 2023
@oxade oxade deleted the fix_potential_name_clobbering branch July 5, 2023 21:48
longbowlu pushed a commit that referenced this pull request Jul 6, 2023
ebmifa pushed a commit that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants